D27778: Use AbstractClient instead of XdgShellClient wherever possible

davidedmundson added a comment.


  Just to confirm as I didn't expect some of this change, the plan is still to have:
  
  class XdgShellTopLevel: public XdgShellClient
  class XdgShellPopup: public XdgShellClient

INLINE COMMENTS

> abstract_client.h:443
>      const QList<AbstractClient*>& transients() const; // Is not indirect
> +    virtual void addTransient(AbstractClient *client);
>      virtual void removeTransient(AbstractClient* cl);

why does this now have to be public?

> workspace.cpp:695
> +{
> +    setupClientConnections(client);
> +    client->updateDecoration(false);

Can you clarify this is just a code move from the above?

It's frustrating to review these patches checking line by line as it takes a lot waaay longer than it took the developer to do the original copy paste.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27778

To: zzag, #kwin
Cc: davidedmundson, kwin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart