D27789: [autotests] Fix failing KeyboardLayoutTest::testNumLock()
Vlad Zahorodnii <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag created this revision. zzag added a reviewer: KWin. Herald added a project: KWin. Herald added a subscriber: kwin. zzag requested review of this revision. REVISION SUMMARY Since Qt::KeypadModifier is set only for keypad keys and not the NumLock key, we need to press at least one keypad key to determine whether numlock is actually on. On the other hand, we know that when numlock is on, the corresponding LED is also on. So we could check the LED rather than press two keys. TEST PLAN testKeyboardLayout passes. REPOSITORY R108 KWin BRANCH check-led-status-in-test-num-lock REVISION DETAIL https://phabricator.kde.org/D27789 AFFECTED FILES autotests/integration/keyboard_layout_test.cpp To: zzag, #kwin Cc: kwin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart