D27788: Implement EGL_KHR_partial_update

Vlad Zahorodnii <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
zzag added inline comments.

INLINE COMMENTS

> egl_gbm_backend.cpp:535
> +
> +            QVector<EGLint> rects = regionToRects(output.damageHistory.constFirst(),
> +                                                  output.output->geometry().height());

This is the region in the buffer which must be repaired, i.e. the damage from the previous frames. Shouldn't we also include the current damage region?

> egl_gbm_backend.cpp:538
> +
> +            bool correct = rects.isEmpty()
> +                         || eglSetDamageRegionKHR(eglDisplay(), output.eglSurface,

IIRC, it is okay to set n_rects to 0 so we probably can drop this check.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27788

To: apol, #kwin, #plasma:_mobile
Cc: zzag, davidedmundson, kwin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.