D27822: Introduce AbstractClient::createDecoration()
Aleix Pol Gonzalez <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
apol added a comment.
+1 looks good!
INLINE COMMENTS
> abstract_client.cpp:2146
> + connect(decoration, &KDecoration2::Decoration::shadowChanged, this, &Toplevel::updateShadow);
> + connect(decoration, &KDecoration2::Decoration::bordersChanged, this, [this]() {
> + GeometryUpdatesBlocker blocker(this);
We are not capturing anything, reads like it could be a normal slot.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D27822
To: zzag, #kwin
Cc: apol, kwin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, ahiemstra, mart