D27788: Implement EGL_KHR_partial_update and EGL_EXT_swap_buffers_with_damage
Vlad Zahorodnii <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag added inline comments.
INLINE COMMENTS
> scene_opengl.h:88
> SceneOpenGL(OpenGLBackend *backend, QObject *parent = nullptr);
> + void aboutToStartPainting(const QRegion & damage) override;
> void paintBackground(QRegion region) override;
Stray whitespace after `&`, please remove it.
> scene.cpp:206-208
> if (!(orig_mask & PAINT_SCREEN_BACKGROUND_FIRST)) {
> paintBackground(infiniteRegion());
> }
In general it shouldn't matter, but I wonder whether paintBackground() must be moved down so we don't call glClear() before eglSetDamageRegionKHR().
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D27788
To: apol, #kwin, #plasma:_mobile
Cc: mwolff, zzag, davidedmundson, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart