D28085: Adapt to new KScreenLocker API
Aleix Pol Gonzalez <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
apol added a comment.
+1 overall
INLINE COMMENTS
> wayland_server.cpp:511
> {
> - ScreenLocker::KSldApp::self();
> - ScreenLocker::KSldApp::self()->setWaylandDisplay(m_display);
> + auto *screenLockerApp = ScreenLocker::KSldApp::self();
> +
Sounds like if KSldApp wasn't a singleton much of the cleanup code would be much simpler. It could maybe make sense to revisit this?
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D28085
To: romangg, #kwin
Cc: apol, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, ahiemstra, mart