D27988: KCM/Compositing: Use KConfig XT in UI

bport requested changes to this revision.
bport added inline comments.

INLINE COMMENTS

> kwincompositing_setting.kcfg:48
> +           <choices>
> +               <choice name="n" />
> +               <choice name="a" />

Perhaps we can add comment, kcfg can be used as documentation

> main.cpp:204
> +
> +    m_settings->setBackend(backend);
> +    m_settings->setGLCore(glCore);

Using m_settings to track unmanaged state lead to settings containing old data and new data. Managed widget update settings only on save.
You will need to use another object to track change in unmanaged widget.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27988

To: meven, #kwin, ervin, crossi, bport, hchain
Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart