D27861: WIP: Rework xdg-shell implementation

zzag added a comment.


  In D27861#629090 <https://phabricator.kde.org/D27861#629090>, @davidedmundson wrote:
  
  > There's a bit to follow up on the ML wrt the protocol location.  Then we can do start a code review.
  
  
  Yep, sounds good. :)

INLINE COMMENTS

> davidedmundson wrote in xdgshellclient_test.cpp:1417
> why is it only coming up now?
> 
> The change in placement.cpp?
> 
> Can they be standalone?

> Urgh, I made a mistake in the window geometry patch series.

Actually, I did not make a mistake.

Originally, the window geometry patch series assumed that we have to compute the effective window geometry when the pending state of xdg_surface is applied.

Then D26233 <https://phabricator.kde.org/D26233>, changed when the window geometry is clamped. It's worth to point out that we didn't take into account the frame geometry in D26233 <https://phabricator.kde.org/D26233>. So, it's quite possible that the frame geometry and the client size may diverge from time to time.

Given that XdgSurfaceClient clamps the window geometry when the main surface has been committed, the frame geometry and the client size cannot diverge anymore. So, this test must be adjusted.

> davidedmundson wrote in xdgshellv6interface.cpp:736
> Not luck, I was the one who changed WMBase for that very reason, glad you agree \o/

Thank you. :-)

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27861

To: zzag, #kwin
Cc: univerz, davidedmundson, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart