D28062: Fix compiler warnings
Aleix Pol Gonzalez <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
apol marked 2 inline comments as done. apol added inline comments. INLINE COMMENTS > zzag wrote in debug_console.cpp:713 > Could you please revert this change? The documentation says that we should use QMetaType. > > I assume the compiler doesn't like conversions between QVariant::Type and QMetaType::Type. If that's the case, we could cast the return value of `value.type()` or use `value.userType()` as Qt folks do. It doesn't make much sense since QVartiant's are defined in terms of QMetaType: `SizeF = QMetaType::QSizeF`. But sure, changing for your peace of mind. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D28062 To: apol, #kwin Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart