D26859: Implement the tablet wayland protocol in kwin

davidedmundson added a comment.


  One minor comment, but I think this is good to go.

INLINE COMMENTS

> input.cpp:1663
> +        case QEvent::TabletMove:
> +            tool->sendMotion(event->globalPosF() - toplevel->pos());
> +            break;

Double check with vlad, but I think we want

toplevel->bufferGeometry().topLeft()

as input is relative to the buffer not the frame

> modifier_only_shortcuts.cpp:62
>              event->modifiersRelevantForGlobalShortcuts() == Qt::NoModifier &&
> -            !workspace()->globalShortcutsDisabled()) {
> +            workspace() && !workspace()->globalShortcutsDisabled()) {
>              if (m_modifier != Qt::NoModifier) {

seems unrelated but I assume this is fixing a teardown crash?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D26859

To: apol, #kwin, #plasma, zzag, davidedmundson
Cc: davidedmundson, zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart