D28085: Adapt to new KScreenLocker API

davidedmundson added inline comments.

INLINE COMMENTS

> apol wrote in wayland_server.cpp:511
> Sounds like if KSldApp wasn't a singleton much of the cleanup code would be much simpler. It could maybe make sense to revisit this?

not sure that's the right.

KSLDApp is the process that launches the screenlocker when needed, it has to have the lifespan of the session.

> wayland_server.cpp:526
> +            }
> +            ScreenLocker::KSldApp::self()->setWaylandFd(clientFd);
> +

why do we do this on every lock?

> wayland_server.cpp:529
> +            for (auto *seat : m_display->seats()) {
> +                connect(seat, &KWayland::Server::SeatInterface::timestampChanged,
> +                        screenLockerApp, &ScreenLocker::KSldApp::userActivity);

Can this be done the other way round in the seat constructor

then we get rid of all these connects and disconnects

> wayland_server.cpp:578
> +    connect(m_screenLockerClientConnection, &KWayland::Server::ClientConnection::disconnected,
> +            this, [this] { m_screenLockerClientConnection = nullptr; });
> +    return socket.fd;

who deletes m_screenLockerClientConnection in this case?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D28085

To: romangg, #kwin
Cc: davidedmundson, apol, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, ahiemstra, mart