D28152: [RFC] KWinRules KCM Redesign
Ismael Asensio <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
iasensio added inline comments. INLINE COMMENTS > broulik wrote in kcmrules.cpp:24 > Don't include the entire module, just include whatever `QDBus` class you're using, but it appears unused in this file anyway? It's used in the `save()` method, to make kwin reload the configuration > broulik wrote in regenerateindex.sh:1 > This file is just for testing, I presume? Yeah, it was on my first attempts when I was figuring everything out, and never noticed it again since. Removed. > broulik wrote in rulesmodel.cpp:43 > I think this should be registered in the KCM constructor, not inside of another type It's related to the 2nd entry point (`kwin_rules_dialog`). Since it does not include the kcm, but just the model, this is the most outer object common to both paths. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D28152 To: iasensio, #plasma, #kwin, #vdg Cc: hchain, broulik, zzag, kwin, dmenig, manueljlin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, mkulinski, trickyricky26, ragreen, jackyalcine, iodelay, crozbo, ndavis, bwowk, ZrenBot, firef, ngraham, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart