D28230: [wayland] Add new XdgOutput properties
Vlad Zahorodnii <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag added inline comments. INLINE COMMENTS > zzag wrote in abstract_wayland_output.cpp:284 > So, I assume you're talking about output mapping for touch devices. If that's the case, we could set the udev 'WL_OUTPUT` property on the input device, but nobody does it. Alternatively, we could follow libinput's documentation [1] and use something else. > > My main concern about this code is that we start mixing identifiers, names, and descriptions, which makes code more difficult to work with and reason about. > > [1] https://wayland.freedesktop.org/libinput/doc/latest/api/group__device.html#gaf48626f6190e9c9bc14abb704e66cc22 We probably don't even need to bother with libinput_device_get_output_name() as long as our output names match weston's output names. I also believe that libinput_device_get_output_name() returns NULL in many cases since I don't see who sets WL_OUTPUT. Either way, worth checking... REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D28230 To: davidedmundson, #kwin, #plasma Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart