D28293: [kcmkwin] Make dialog non blocking
David Edmundson <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: KWin. Herald added a subscriber: kwin. davidedmundson requested review of this revision. REVISION SUMMARY It's invoked from QML. Nested event loops invoked directly from QML is asking for crashes. BUG: 419118 TEST PLAN Opened KCM Opened dialog for some settings Window was still modal as before Settings were saved (though they didn't seem to be applied..maybe another bug?) REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D28293 AFFECTED FILES kcmkwin/common/effectsmodel.cpp To: davidedmundson, #kwin Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart