D27339: Implement input methods
Aleix Pol Gonzalez <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
apol marked 4 inline comments as done. apol added a comment. > I came only halfway through the patch, but I don't think that it's a good idea to keep xdg-shell specific bits in WaylandClient. I'm not sure which parts you mean. I tried to keep some bits so it's easier to re-use the class. If there's something that really rubs you the wrong way, I can look into moving. That said, it seems to me like XdgShellClient could use its own splitting at some point and I don't want to overengineer the process at this stage. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D27339 To: apol, #kwin Cc: davidedmundson, zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart