D28320: [kwineffects] Port GLPlatform to QRegularExpression

Aleix Pol Gonzalez <[email protected]> Fri, 27 Mar 2020 11:09:28 +0000

Newsgroups	gmane.comp.kde.devel.kwin
Message-ID	<[email protected]>

apol added inline comments.

INLINE COMMENTS

> zzag wrote in kwinglplatform.cpp:97
> Yes, it would be great, but could we maybe do it in another patch? QString and QStringRef have minor API differences so it's not just about replacing a few QStrings by QStringRefs. Such a change would look unrelated if you ask me.

Yes, the patch is accepted, feel free to land.

REPOSITORY
  R108 KWin

BRANCH
  port-kwinglplatform-to-qregularexpression

REVISION DETAIL
  https://phabricator.kde.org/D28320

To: zzag, #kwin, apol
Cc: apol, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, ahiemstra, mart