D27988: KCM/Compositing: Use KConfig XT in UI

zzag requested changes to this revision.
zzag added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> main.cpp:40
> +
> +static bool isRunningPlasma() {
> +    return qgetenv("XDG_CURRENT_DESKTOP") == "KDE";

Since isRunningPlasma is static, you don't need to put it in an anonymous namespace. Also, coding style nitpick: `{` must be on its own line.

> main.cpp:259
> +        }
> +    } else {
> +        m_form.backend->setCurrentIndex(CompositingTypeIndex::XRENDER_INDEX);

We need to initialize m_glCore to something; otherwise it will cause problems in updateUnmanagedItemStatus() later on.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27988

To: meven, #kwin, ervin, crossi, bport, hchain, zzag
Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart