D28152: KWinRules KCM Redesign

zzag added inline comments.

INLINE COMMENTS

> RulesEditor.qml:89
> +            QQC2.SpinBox {
> +                id: detection_delay
> +                Layout.minimumWidth: Kirigami.Units.gridUnit * 6

Use camelCase please.

> RulesEditor.qml:93-96
> +                textFromValue: (value, locale) => {
> +                    return (value == 0) ? i18n("Instantly")
> +                                        : i18np("After 1 second", "After %1 seconds", value)
> +                }

If an implementation for textFromValue is provided, then we also must provide an implementation for valueFromText.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D28152

To: iasensio, #plasma, #kwin, #vdg
Cc: davidedmundson, hchain, broulik, zzag, kwin, dmenig, manueljlin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, mkulinski, trickyricky26, ragreen, jackyalcine, iodelay, crozbo, ndavis, bwowk, ZrenBot, firef, ngraham, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart