D28630: [xwl] Fix crash if same data is requested twice
David Edmundson <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: KWin. Herald added a subscriber: kwin. davidedmundson requested review of this revision. REVISION SUMMARY m_dataRequests is a list of transfers for a given selection. It exists primarily as a ref counting mechanism that matches up transfers with selections. If the same data is requested twice we would insert two items into the list with matching timestamps for the original selection. This then confuses the callback handling. BUG: 417936 TEST PLAN kwin_wayland + chromium drag and drop a URL onto desktopview. kwin used to crash here Now a context menu now appears and I can add a link REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D28630 AFFECTED FILES xwl/drag_x.cpp To: davidedmundson, #kwin Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart