D27862: KCM KWinTouchScreen port to KConfigXT

Kevin Ottens <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.


  Two little things.

INLINE COMMENTS

> kwinscreenedge.cpp:35
> +
> +KWin::KWinScreenEdge::~KWinScreenEdge()
> +{

That KWin namespace is redundant here.

> kwinscreenedge.cpp:77
> +{
> +    QList<int> list = QList<int>();
> +    if (monitor()->selectedEdgeItem(Monitor::Top) == index) {

Either:
`auto list = QList<int>();`
or
`QList<int> list;`

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27862

To: crossi, #kwin, ervin, bport, meven, zzag
Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.