D28617: Remove QSessionManager usage
David Edmundson <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > apol wrote in sm.cpp:357 > Care to elaborate? what do you have in mind here? > > Feels like it could end up being one of these TODO that stay forever Ack, I rarely see a TODO and act upon it in any meaningful way. IMHO it's not a problem as-is. One is a request for kwin to perform an action, the other is a property of the state the whole session should be in. It allows us to be more explicit that we're shutting down or whatever which could outlive session management operations and to separate ksmserver specific code further. REPOSITORY R108 KWin BRANCH broulik/no_ksmserver REVISION DETAIL https://phabricator.kde.org/D28617 To: broulik, #kwin, davidedmundson Cc: davidedmundson, apol, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, ahiemstra, mart