D28667: [platforms/x11] Fix valigrind warning copying window icon for windowed mode

Vlad Zahorodnii <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
zzag added inline comments.

INLINE COMMENTS

> x11windowed_output.cpp:104
> +        QImage windowImage = windowIcon.pixmap(size).toImage();
> +        icon.data = windowImage.bits();
>          icon.size.width = size.width();

Please make windowImage const so we don't copy data twice over here.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D28667

To: davidedmundson, #kwin, apol
Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.