D28674: Implement a updateXTime compatible with Xcb and XWayland

Méven Car <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
meven added inline comments.

INLINE COMMENTS

> zzag wrote in CMakeLists.txt:512
> Please keep filenames in alphabetical order. Tip: open vim, select relevant lines in the visual mode, and run the `sort` command.

I am using qtcreator btw.

> zzag wrote in workspace.h:674
> I know that QScopedPointer sucks, but I suggest to use it anyway for the consistency sake.

Did not know this about `QScopedPointer`
`std::unique_ptr` is used in this file `std::unique_ptr<Xcb::Tree> m_xStackingQueryTree;`

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D28674

To: meven, #kwin, davidedmundson, zzag
Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.