D28668: [wayland] Fix teardown order
Vlad Zahorodnii <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag added inline comments. INLINE COMMENTS > zzag wrote in wayland_server.cpp:640 > Wouldn't it be better to destroy the event queue explicitly in destroyInternalConnection()? It would be a more robust (what if other globals need to access the event queue during tear down too?) and easier solution (a "flat" tear down sequence is much easier to understand than the one where children are destroyed together with their parent implicitly), imho. > > [1] In fact, we got a bug or two because of "unexpected" (technically, it was okay; but conceptually it wasn't) tear down order of parents and their children. implicitly [1])* REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D28668 To: davidedmundson, #kwin, cblack, apol Cc: zzag, apol, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, ahiemstra, mart