D28674: Implement a updateXTime compatible with Xcb and XWayland

zzag added inline comments.

INLINE COMMENTS

> workspace.cpp:451-457
> +    if (Xcb::Extensions::self()->isSyncAvailable()) {
> +        connect(kwinApp(), &Application::workspaceCreated, this,
> +            [this] {
> +                QScopedPointer<SyncAlarmNotifyX11Filter> m_syncFilter(new SyncAlarmNotifyX11Filter());
> +            }
> +        );
> +    }

You don't need a `connect` and `m_syncFilter` is shadowed.

  if (Xcb::Extensions::self()->isSyncAvailable()) {
      m_syncFilter.reset(new SyncAlarmNotifyX11Filter);
  }

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D28674

To: meven, #kwin, davidedmundson, zzag
Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart