D27788: Implement EGL_KHR_partial_update and EGL_EXT_swap_buffers_with_damage
Vlad Zahorodnii <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag added inline comments.
INLINE COMMENTS
> scene.cpp:234-235
>
> + damaged_region = QRegion(QRect {{}, screens()->size()});
> + aboutToStartPainting(damaged_region);
> +
So, when the slide effect is active, aboutToStartPainting() may be called up to 4 times. We have to check m_paintScreenCount before calling aboutToStartPainting().
> scene.cpp:353-358
> + aboutToStartPainting(dirtyArea);
> +
> QRegion paintedArea;
> // Fill any areas of the root window not covered by opaque windows
> + if (m_paintScreenCount == 1) {
> + aboutToStartPainting(dirtyArea);
aboutToStartPainting() should not be called twice.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D27788
To: apol, #kwin, #plasma:_mobile
Cc: mwolff, zzag, davidedmundson, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart