D28152: KWinRules KCM Redesign

iasensio updated this revision to Diff 80472.
iasensio added a comment.


  As suggested by @ngraham in the #VDG <https://phabricator.kde.org/tag/vdg/> channel, this changes the metaphor to select new properti>
  Instead of a `Show All` filter, now we can add properties to the rule using an overlay sheet.
  The `Detect window properties` option also uses the sheet to show and select them, which was a>
  
  There are some UI/QML quirks with the overlay I'm not able to get rid of:
  
  - The first item in the ListView goes under the section header until it's repainted
  - Some items misaling the right button
  - Cannot set the focus to the search field

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28152?vs=80337&id=80472

BRANCH
  wip/overlay

REVISION DETAIL
  https://phabricator.kde.org/D28152

AFFECTED FILES
  kcmkwin/kwinrules/CMakeLists.txt
  kcmkwin/kwinrules/detectwidget.cpp
  kcmkwin/kwinrules/detectwidget.h
  kcmkwin/kwinrules/detectwidget.ui
  kcmkwin/kwinrules/editshortcut.ui
  kcmkwin/kwinrules/kcm.cpp
  kcmkwin/kwinrules/kcm.h
  kcmkwin/kwinrules/kcm_kwinrules.desktop
  kcmkwin/kwinrules/kcmrules.cpp
  kcmkwin/kwinrules/kcmrules.h
  kcmkwin/kwinrules/kwinrules.desktop
  kcmkwin/kwinrules/main.cpp
  kcmkwin/kwinrules/optionsmodel.cpp
  kcmkwin/kwinrules/optionsmodel.h
  kcmkwin/kwinrules/package/contents/ui/FileDialogLoader.qml
  kcmkwin/kwinrules/package/contents/ui/OptionsComboBox.qml
  kcmkwin/kwinrules/package/contents/ui/RuleItemDelegate.qml
  kcmkwin/kwinrules/package/contents/ui/RulesEditor.qml
  kcmkwin/kwinrules/package/contents/ui/RulesList.qml
  kcmkwin/kwinrules/package/contents/ui/ValueEditor.qml
  kcmkwin/kwinrules/package/metadata.desktop
  kcmkwin/kwinrules/rulebookmodel.cpp
  kcmkwin/kwinrules/rulebookmodel.h
  kcmkwin/kwinrules/ruleitem.cpp
  kcmkwin/kwinrules/ruleitem.h
  kcmkwin/kwinrules/rulesdialog.cpp
  kcmkwin/kwinrules/rulesdialog.h
  kcmkwin/kwinrules/ruleslist.cpp
  kcmkwin/kwinrules/ruleslist.h
  kcmkwin/kwinrules/ruleslist.ui
  kcmkwin/kwinrules/rulesmodel.cpp
  kcmkwin/kwinrules/rulesmodel.h
  kcmkwin/kwinrules/ruleswidget.cpp
  kcmkwin/kwinrules/ruleswidget.h
  kcmkwin/kwinrules/ruleswidgetbase.ui
  kcmkwin/kwinrules/yesnobox.cpp
  kcmkwin/kwinrules/yesnobox.h

To: iasensio, #plasma, #kwin, #vdg
Cc: ngraham, davidedmundson, hchain, broulik, zzag, kwin, dmenig, manueljlin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, mkulinski, trickyricky26, ragreen, jackyalcine, iodelay, crozbo, ndavis, bwowk, ZrenBot, firef, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart