D28152: KWinRules KCM Redesign

davidedmundson accepted this revision.
davidedmundson added a comment.


  If you haven't done so already, I would suggest attaching QAbstractItemModelTester to rulesModel and move stuff about. It's really good at finding technical quirks.
  
  But in general +++ I couldn't find any real technical problems \o/
  
  I say we try and merge it early so we can get some wider testing.

INLINE COMMENTS

> rulesmodel.cpp:705
> +    QList<OptionsModel::Data> modelData;
> +    for (int desktopId = 1; desktopId <= KWindowSystem::numberOfDesktops(); ++desktopId) {
> +        modelData << OptionsModel::Data{

This won't work on wayland, we will want to copy whatever we do in the virtual desktop KCM.

I think this is not regression, as the current code does the same.
At which point I'm happy to merge now and revist it later.

REPOSITORY
  R108 KWin

BRANCH
  wip/overlay

REVISION DETAIL
  https://phabricator.kde.org/D28152

To: iasensio, #plasma, #kwin, #vdg, ngraham, davidedmundson
Cc: ngraham, davidedmundson, hchain, broulik, zzag, kwin, dmenig, manueljlin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, mkulinski, trickyricky26, ragreen, jackyalcine, iodelay, crozbo, ndavis, bwowk, ZrenBot, firef, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart