D29122: ScreenShotEffect: Add a shouldReturnNativeSize argument to screenshotFullscreen

Kai Uwe Broulik <[email protected]> Thu, 23 Apr 2020 09:29:26 +0000

Newsgroups	gmane.comp.kde.devel.kwin
Message-ID	<[email protected]>

broulik added inline comments.

INLINE COMMENTS

> screenshot.h:104
>       */
> -    Q_SCRIPTABLE void screenshotFullscreen(QDBusUnixFileDescriptor fd, bool captureCursor = false);
> +    Q_SCRIPTABLE void screenshotFullscreen(QDBusUnixFileDescriptor fd, bool captureCursor = false, bool shouldReturnNativeSize = false);
>      /**

I think we could consider this interface public API and adding new arguments changes the DBus signature iirc.
Perhaps we should just add a new overload.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D29122

To: meven, #kwin, davidedmundson, bport, zzag, apol
Cc: broulik, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart