D29122: ScreenShotEffect: Add a shouldReturnNativeSize argument to screenshotFullscreen

davidedmundson added a comment.


  > I think we could consider this interface public API and adding new arguments changes the DBus signature iirc.
  
  Perhaps we should just add a new overload.
  
  You're right that DBus would fail if you don't call with the right number of arguments to match a method signature, but you underestimate QtDBus. It's /amaaaazing/
  
  It knows some arguments are defaults, for the existing code it currently generates:
  
    <method name="screenshotScreen">
      <arg name="fd" type="h" direction="in"/>
      <arg name="captureCursor" type="b" direction="in"/>
    </method>
    <method name="screenshotScreen">
      <arg name="fd" type="h" direction="in"/>
    </method>
  
  In this case it'll just add a 3rd.
  
  Though @meven can you just run qdbus org.kde.KWin /Screenshot org.freedesktop.DBus.Introspectable.Introspect and double check.

INLINE COMMENTS

> screenshot.cpp:409
> +                p.end();
> +
> +                sendReplyImage(multipleOutputsImage);

Please clear m_cacheOutputsImages so we're not wasting ram

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D29122

To: meven, #kwin, davidedmundson, bport, zzag, apol
Cc: broulik, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart