D27788: Implement EGL_KHR_partial_update and EGL_EXT_swap_buffers_with_damage
Vlad Zahorodnii <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag added inline comments.
INLINE COMMENTS
> scene.cpp:235
> + damaged_region = QRegion(QRect {{}, screens()->size()});
> + if (m_paintScreenCount == 1) {
> + aboutToStartPainting(damaged_region);
You must call paintBackground if PAINT_SCREEN_BACKGROUND_FIRST is called.
> scene.cpp:240
> + if (!(orig_mask & PAINT_SCREEN_BACKGROUND_FIRST)) {
> + Q_ASSERT(m_paintScreenCount == 1);
> + paintBackground(infiniteRegion());
In general, an effect is allowed to call paintScreen() multiple times without setting PAINT_SCREEN_BACKGROUND_FIRST.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D27788
To: apol, #kwin, #plasma:_mobile
Cc: mwolff, zzag, davidedmundson, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart