D29145: Rules kcm: Use new property ComboBox.currentValue

Ismael Asensio <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
iasensio created this revision.
iasensio added reviewers: ngraham, KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
iasensio requested review of this revision.

REVISION SUMMARY
  Use the property `currentValue`, introduced in Qt5.14 for QQC2.ComboBox
  
  It didn't work before due to some Qt version inheritance not updated in the QQC2 templates.
  It is now required to fix:
  
    "file:///home/nate/kde/usr/share/kpackage/kcms/kcm_kwinrules/contents/ui/RulesEditor.qml" 
    "Error loading QML file.\n42: Type RuleItemDelegate unavailable\n68: Type OptionsComboBox unavailable\n35: Cannot override FINAL property\n"
    QCoreApplication::postEvent: Unexpected null receiver

TEST PLAN
  Try to edit a rule or add a new one.
  The rule editor page shows.

REPOSITORY
  R108 KWin

BRANCH
  fix/currentvalue

REVISION DETAIL
  https://phabricator.kde.org/D29145

AFFECTED FILES
  kcmkwin/kwinrules/package/contents/ui/OptionsComboBox.qml

To: iasensio, ngraham, #kwin
Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.