D29055: [Wayland] Send stacking order event through plasma window management protocol

Vlad Zahorodnii <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
zzag added inline comments.

INLINE COMMENTS

> wayland_server.cpp:496
> +                QVector<quint32> ids;
> +                for (auto c: workspace()->stackingOrder()) {
> +                    auto *client = qobject_cast<AbstractClient*>(c);

- No short variable names please.
- Don't erase types if it makes reading code more difficult

  for (Toplevel *toplevel : workspace()->stackingOrder()) {
      auto client = qobject_cast<AbstractClient *>(toplevel);
      // ...
  }

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D29055

To: bport, zzag, davidedmundson, meven
Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.