D29055: [Wayland] Send stacking order event through plasma window management protocol

zzag requested changes to this revision.
zzag added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> wayland_server.cpp:496
> +                QVector<quint32> ids;
> +                for (Toplevel *client: workspace()->stackingOrder()) {
> +                    auto *abstract_client = qobject_cast<AbstractClient *>(client);

stackingOrder() doesn't necessarily contains only clients. It can also contain Deleted toplevels. Please rename client to toplevel. We also put whitespace before and after `:`.

> wayland_server.cpp:497
> +                for (Toplevel *client: workspace()->stackingOrder()) {
> +                    auto *abstract_client = qobject_cast<AbstractClient *>(client);
> +                    if (abstract_client && abstract_client->windowManagementInterface()) {

No snake_case please.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D29055

To: bport, zzag, davidedmundson, meven
Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart