D29263: Position OSD a bit farther down
Nathaniel Graham <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
ngraham created this revision. Herald added a project: KWin. Herald added a subscriber: kwin. ngraham requested review of this revision. REVISION SUMMARY A common user complains is that our OSDs--particularly the volume OSD--are too intrusive and get in the way of the screen content. For example when adjusting the volume while watching a full-screen video, the volume change OSD will typically appear right in the middle of an actor's face. D20569 <https://phabricator.kde.org/D20569> was an attempt to use a horizontal OSD to alleviate this issue. It mostly worked, but IMO it was still positioned too high up. This patch moved the placement down a little bit to make the OSD appear even farther from the center of the screen to make it less likely to I tried not to move it down too far or else it would interfere with subtitles in videos. TEST PLAN F8269172: Screenshot_20200428_123436.png <https://phabricator.kde.org/F8269172> F8269164: Screenshot_20200428_122838.png <https://phabricator.kde.org/F8269164> F8269163: Screenshot_20200428_122229.png <https://phabricator.kde.org/F8269163> REPOSITORY R108 KWin BRANCH position-osd-a-bit-farther-down (branched from master) REVISION DETAIL https://phabricator.kde.org/D29263 AFFECTED FILES placement.cpp To: ngraham Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart