D29278: Port KWin to KWaylandServer

zzag added a comment.


  Hmm, I can't build kwin
  
    /home/vlad/Workspace/KDE/src/kde/workspace/kwin/libkwineffects/kwineffects.cpp:44:10: fatal error: KWaylandServer/surface_interface.h: No such file or directory
       44 | #include <KWaylandServer/surface_interface.h>
          |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    compilation terminated.

INLINE COMMENTS

> CMakeLists.txt:131
> +    TYPE REQUIRED
> +    PURPOSE "For screenlocker integration in kwin_wayland"
> +)

Well, we need it to make the wayland session work.

> CMakeLists.txt:644
>      KF5::WaylandClient
> -    KF5::WaylandServer
> +    Plasma::KWaylandServer
>      Wayland::Cursor

I feel like it should be KWaylandServer::KWaylandServer but we can revisit it.

> kwineffects.h:68
>  
> -namespace KWayland {
> -    namespace Server {
> -        class SurfaceInterface;
> -        class Display;
> -    }
> +namespace KWaylandServer {
> +    class SurfaceInterface;

This breaks source compatibility, but I guess we don't have a choice.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D29278

To: apol, #kwin, #plasma, #frameworks
Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart