D29270: Fix broken localization of kcmkwinrules

davidedmundson added inline comments.

INLINE COMMENTS

> zzag wrote in Messages.sh:2
> Could someone explain why we don't need to use i18nd in Destop Effects or Virtual Desktops KCM?

It all comes from

configmodule.cpp in kdeclarative

QQuickItem *ConfigModule::mainUi()

  d->_qmlObject->setTranslationDomain(aboutData()->componentName());

If this is set then anything loaded within this QML Context will have the right domain.
We do use ConfigModule in this case.

> kcmrules.cpp:    auto about = new KAboutData(QStringLiteral("kcm_kwinrules"),

So as Vlad says from what I can tell if this pot is renamed it should magically start working without i18nd.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D29270

To: yurchor, #kwin, broulik
Cc: davidedmundson, iasensio, victorr, broulik, pino, ltoscano, zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart