D29473: [kcmkwin/kwindecoration] Don't exec() QDialog

Kai Uwe Broulik <[email protected]> Wed, 6 May 2020 08:22:39 +0000

Newsgroups	gmane.comp.kde.devel.kwin
Message-ID	<[email protected]>

broulik created this revision.
broulik added reviewers: KWin, davidedmundson.
Herald added a project: KWin.
Herald added a subscriber: kwin.
broulik requested review of this revision.

REVISION SUMMARY
  Using nested event loops with QML is always troublesome.
  
  BUG: 421053
  FIXED-IN: 5.18.6

TEST PLAN
  - Can edit plastik settings without it crashing, saving settings applies immediately
  - Can edit breeze settings still, saving settings applies immediately

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D29473

AFFECTED FILES
  kcmkwin/kwindecoration/declarative-plugin/previewbridge.cpp
  kcmkwin/kwindecoration/declarative-plugin/previewbridge.h
  kcmkwin/kwindecoration/package/contents/ui/Themes.qml

To: broulik, #kwin, davidedmundson
Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart