D29477: Change CommandAllKey to Meta
Noah Davis <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
ndavis created this revision. ndavis added reviewers: KWin, VDG. Herald added a project: KWin. Herald added a subscriber: kwin. ndavis requested review of this revision. REVISION SUMMARY Alt + Left Click to move windows has a tendency to conflict with creative workflow apps. While Alt can be changed to Meta in KWin's settings, Alt + Left Click shortcuts often cannot be customized in apps. Rather than making every user who runs into this problem change their settings, we should change our default settings to improve KWin's default usability. The fact that Alt + Left Click to move windows is older does not matter. We are trying to use Meta for global/shell shortcuts anyway. TEST PLAN The relevant parts of the relevant tests pass. kwin-testInternalWindow fails, but for unrelated reasons that have something to do with XWayland. REPOSITORY R108 KWin BRANCH click-move-shortcut (branched from master) REVISION DETAIL https://phabricator.kde.org/D29477 AFFECTED FILES autotests/integration/internal_window.cpp autotests/integration/pointer_constraints_test.cpp autotests/integration/pointer_input.cpp kcmkwin/kwinoptions/actions.ui kcmkwin/kwinoptions/kwinoptions_settings.kcfg kwin.kcfg options.cpp To: ndavis, #kwin, #vdg Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart