D29486: xdgshellclient: Allow menus from panels to take focus
David Edmundson <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
davidedmundson added a comment. Yeah I was asking for the "Why this happens in the first place:". Unless we are sure what the cause is, we can't be sure of what the correct fix is. > Normally, QMenus don't grab keyboard focus themselves, and instead the parent window takes keyboard events and uses it to update the state of the QMenu. That doesn't sound right. > The problem is that popup grabs from the xdg-shell spec aren't implemented in kwayland-server. :/ I don't follow what you're referring to. We have XdgShellInterface::popupGrabRequested mapped correctly. Tooltips and menus are correctly differentiated. We don't check the seat and serial properly, but if anything that means we're more likely to acknowledge a grab. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D29486 To: cblack, #kwin, zzag Cc: zzag, davidedmundson, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart