D27861: WIP: Rework xdg-shell implementation
Vlad Zahorodnii <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag added inline comments. INLINE COMMENTS > davidedmundson wrote in wayland_server.cpp:149 > This can never be true. > It's a protocol error on XDGShell to map before configure Well, yeah. I just wanted to keep things as generic as possible. Will remove it. > davidedmundson wrote in xdgshellclient.cpp:1428 > I can't see panelTakesFocusChanged. > > I strongly suspect this will break Kai's reply notifications. > > Arguably the event name doesn't match the usage, but this isn't the time and place for that. There's a good chance that I overlooked it while I was resolving merge conflicts. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D27861 To: zzag, #kwin Cc: anthonyfieroni, univerz, davidedmundson, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart