D29702: Autotests: Add a test when relaunching a maximized cliend with BorderlessMaximizedWindows

zzag requested changes to this revision.
zzag added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> maximize_test.cpp:228-230
> +    QScopedPointer<Surface> surface(Test::createSurface());
> +    QScopedPointer<XdgShellSurface> shellSurface(
> +        Test::createXdgShellStableSurface(surface.data(), surface.data(), Test::CreationSetup::CreateOnly));

We also need to create zxdg_toplevel_decoration_v1 and tell the compositor that we prefer server-side decorations.

> maximize_test.cpp:244
> +
> +    AbstractClient *client = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
> +

We need to ack the configure event.

  shellSurface->ackConfigure(configureRequestedSpy.last().at(2).value<quint32>());

> maximize_test.cpp:246-247
> +
> +    QVERIFY(!client->isDecorated());
> +    QVERIFY(client->noBorder());
> +    // but still server-side

Please check the geometry and the maximized state.

> maximize_test.cpp:249
> +    // but still server-side
> +    configureRequestedSpy.wait();
> +

Use QVERIFY

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D29702

To: meven, #kwin, zzag, davidedmundson
Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart