D29772: Don't compare string with empty string
Kai Uwe Broulik <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
broulik added inline comments.
INLINE COMMENTS
> FileDialogLoader.qml:39
> selectExisting: !root.isSaveDialog
> - folder: (root.lastFolder == "") ? shortcuts.home : root.lastFolder
> + folder: (root.lastFolder.length === 0) ? shortcuts.home : root.lastFolder
> nameFilters: [ i18n("KWin Rules (*.kwinrule)") ]
Why not just `!root.lastFolder`? or even
root.lastFolder || shortcuts.home
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D29772
To: ognarb, #plasma, iasensio
Cc: broulik, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart