D29791: [kcm/kwinrules] Detect also window complete class

Ismael Asensio <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
iasensio created this revision.
iasensio added reviewers: ngraham, KWin, Plasma.
Herald added a project: KWin.
Herald added a subscriber: kwin.
iasensio requested review of this revision.

REVISION SUMMARY
  When detecting the properties of a window, now it shows and lets the user select the window complete class.
  When this property is selected in the overlay, `Window class` takes the whole class value, and the option `Match window whole class` is set.
  
  This was not a bug itself, but a known regression from the old kcm which offered this feature. 
  As such, and introducing a new i18n string, I don't know wether it should be included in 5.19 or 5.20 release.
  
  BUG: 421542
  FIXED-IN: 5.??

TEST PLAN
  - `Detect window properties` and pick a firefox window
  - The property selector shows: `Window class: navigator` and `Whole window class:
  
  navigator firefox`
  
  - Selecting the latter set the properties as per summary

REPOSITORY
  R108 KWin

BRANCH
  wmclasscomplete

REVISION DETAIL
  https://phabricator.kde.org/D29791

AFFECTED FILES
  kcmkwin/kwinrules/ruleitem.cpp
  kcmkwin/kwinrules/ruleitem.h
  kcmkwin/kwinrules/rulesmodel.cpp

To: iasensio, ngraham, #kwin, #plasma
Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.