D29786: Scripting: Provides methods to create and remove virtual desktops
Tiago CorrĂȘa <[email protected]> Mon, 18 May 2020 15:45:29 +0000
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
tcorreabr added inline comments. INLINE COMMENTS > zzag wrote in workspace_wrapper.cpp:282-283 > coding style nit: whitespace before `*` and put the return statement on a new line. Ok. I'll do it. > zzag wrote in workspace_wrapper.h:260 > why not in range [0, count]? I don't know why but the client.desktop property is not zero based, at least on X11. So in a situation with 2 desktops, the new desktop can be inserted at position 1, 2 or 3. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D29786 To: tcorreabr, #kwin Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart