D29791: [kcm/kwinrules] Detect also window complete class

Méven Car <[email protected]> Thu, 28 May 2020 06:26:14 +0000

Newsgroups	gmane.comp.kde.devel.kwin
Message-ID	<[email protected]>

meven added inline comments.

INLINE COMMENTS

> rulesmodel.cpp:181
> +{
> +    for (int row = 0; row < m_ruleList.count(); row++) {
> +        if (m_ruleList.at(row)->key() == key) {

Could you `for (const RuleItem *rule : qAsConst(m_ruleList)) {` c++ style

REPOSITORY
  R108 KWin

BRANCH
  wmclasscomplete

REVISION DETAIL
  https://phabricator.kde.org/D29791

To: iasensio, ngraham, #kwin, #plasma, meven
Cc: davidedmundson, meven, anthonyfieroni, zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart