D29791: [kcm/kwinrules] Detect also window complete class

Ismael Asensio <[email protected]> Thu, 28 May 2020 21:39:37 +0000
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
iasensio added inline comments.

INLINE COMMENTS

> broulik wrote in rulesmodel.cpp:181
> Or you could use `std::find_if`

Here we needed the position in the array, not the item itself,  to build the `index` within the model. But in fact, there's the proper `match` method for that.

> broulik wrote in rulesmodel.cpp:401
> "whole class" reads odd imho but I'm not a native speaker

You are right, it should say "whole window class", like the previous property.

REPOSITORY
  R108 KWin

BRANCH
  wmclasscomplete

REVISION DETAIL
  https://phabricator.kde.org/D29791

To: iasensio, ngraham, #kwin, #plasma, meven
Cc: broulik, davidedmundson, meven, anthonyfieroni, zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart