D21076: ICC Color Correction Effect

rjvbb added a comment.


  > Hm, and by not working you mean that the translucency effect gets canceled, but the correction itself works, right?
  
  Yep.
  
  > Are you sure you applied the newer patch? One with the `tex *= modulation` line in icc.frag? Also are you sure you installed the resulting libkwin4_effect_builtins.so correctly?
  
  I got this one: `https://github.com/vitalif/kwin/commit/83d69c928574de388d8f27ec6948f307b4eab3f2.patch` following the link to your github repo you posted earlier, but I see no occurence of that modulation pattern in that commit. In fact, I now see that it looks like an old commit - so where is that newer one?

REVISION DETAIL
  https://phabricator.kde.org/D21076

To: vitaliyf, zzag, rjvbb
Cc: knechtges, rjvbb, graesslin, davidedmundson, zzag, ngraham, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart