D4135: Split implementation of keyboard layout handling into a dedicated class

Andrey Butirsky <[email protected]> Thu, 10 Dec 2020 20:25:32 +0000
Newsgroups gmane.comp.kde.devel.plasma,gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
bam added inline comments.

INLINE COMMENTS

> keyboard_input.cpp:709
>      m_modifiersChangedSpy->updateModifiers(modifiers());
> +    m_keyboardLayout->checkLayoutChange();
>  }

I'm not quite follow the check here and whole processModifiers() method:
it's occurs after client gets the modifiers event, right?
But at this moment, the modifiers are already updated on server, isn't it?
Sorry I might miss something.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D4135

To: graesslin, #plasma_on_wayland, #kwin, bshah
Cc: bam, bshah, plasma-devel, kwin, adam, retsim, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, hannahk, jraleigh, zachus, sgureev, fbampaloukas, mkulinski, ragreen, jackyalcine, schernikov, iodelay, crozbo, spoorun, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, eliasp, sebas, apol, ahiemstra, mart