Re: Kwin Maintainers Approval for Rounding Bottom Corners
Niccolò Venerandi of KDE <[email protected]> Mon, 28 Jun 2021 20:42:32 +0200
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <CAHWRx6Spiww-ZSmidNudUQrn9VUQ9iuKTVofnuFVuh9usaXPjQ@mail.gmail.com> |
--000000000000dec9f405c5d7daf3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable After discussing with some members of the VDG, I understand the performance concerns. I agree we should choose performance over rounded corners. Thank you Vlad for the clear reply! Il lun 28 giu 2021, 20:25 Vlad Zahorodnii <[email protected]> ha scritto: > On 6/28/21 12:25 PM, Martin Fl=C3=B6ser wrote: > > Am Samstag, 26. Juni 2021, 00:25:29 CEST schrieb Aleix Pol: > >> Are you sure this is something that needs tackling at KWin level? if > KWin > >> cuts down there's the possibility that an app might get cut off. An > >> application (e > >> g. at kirigami level) could decide though to have round corners by > offering > >> a transparent mask. Would that be more in line with what you are after= ? > > > > I absolutely agree with Aleix here. This is nothing a window manager > should > > do. This can break applications in horrible and unexpected ways. Please > do not > > go down this route. We do not know what the application draws and how i= t > > interacts with the window - where there are controls, etc. > > Right, besides the technical issues with client-side decorated > applications, rounding corners on the compositor side will effectively > kill optimizations such as directly scanning out sub-surfaces on > hardware planes. The compositor will be forced to perform compositing. > > It's totally understandable why VDG wants the bottom window corners be > rounded by the compositor, but it's simply not possible due to various > technical reasons. > > Cheers, > Vlad > > > Just imagine a video application without borders and you cut off pixels > or a > > virtual machine where the virtualized operating system is not square. > > > > If you want to do design, please do it in parts of your design. Don't > force it > > on apps which are not controlled by us. And if we do it only for our > > controlled apps the better place to implement it, is in the apps or > Breeze > > style. > > > > Cheers > > Martin > > > > > > --000000000000dec9f405c5d7daf3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"auto">After discussing with some members of the VDG, I understa= nd the performance concerns. I agree we should choose performance over roun= ded corners. Thank you Vlad for the clear reply!</div><br><div class=3D"gma= il_quote"><div dir=3D"ltr" class=3D"gmail_attr">Il lun 28 giu 2021, 20:25 V= lad Zahorodnii <<a href=3D"mailto:[email protected]" target=3D"_bl= ank" rel=3D"noreferrer">[email protected]</a>> ha scritto:<br></di= v><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:= 1px #ccc solid;padding-left:1ex">On 6/28/21 12:25 PM, Martin Fl=C3=B6ser wr= ote:<br> > Am Samstag, 26. Juni 2021, 00:25:29 CEST schrieb Aleix Pol:<br> >> Are you sure this is something that needs tackling at KWin level? = if KWin<br> >> cuts down there's the possibility that an app might get cut of= f. An<br> >> application (e<br> >> g. at kirigami level) could decide though to have round corners by= offering<br> >> a transparent mask. Would that be more in line with what you are a= fter?<br> > <br> > I absolutely agree with Aleix here. This is nothing a window manager s= hould<br> > do. This can break applications in horrible and unexpected ways. Pleas= e do not<br> > go down this route. We do not know what the application draws and how = it<br> > interacts with the window - where there are controls, etc.<br> <br> Right, besides the technical issues with client-side decorated <br> applications, rounding corners on the compositor side will effectively <br> kill optimizations such as directly scanning out sub-surfaces on <br> hardware planes. The compositor will be forced to perform compositing.<br> <br> It's totally understandable why VDG wants the bottom window corners be = <br> rounded by the compositor, but it's simply not possible due to various = <br> technical reasons.<br> <br> Cheers,<br> Vlad<br> <br> > Just imagine a video application without borders and you cut off pixel= s or a<br> > virtual machine where the virtualized operating system is not square.<= br> > <br> > If you want to do design, please do it in parts of your design. Don= 9;t force it<br> > on apps which are not controlled by us. And if we do it only for our<b= r> > controlled apps the better place to implement it, is in the apps or Br= eeze<br> > style.<br> > <br> > Cheers<br> > Martin<br> > <br> > <br> <br> </blockquote></div> --000000000000dec9f405c5d7daf3--